Notifications assets full support #2295
Conversation
danielayala94
added
the
area-Notifications
danielayala94
requested review from
sharath2727,
loneursid,
hulumane,
David-Quero and
robertzhou-wpn
ghost
added
the
| // subKey: \Software\Classes\AppUserModelId\{AppGUID} | ||
| std::wstring subKey{ c_appIdentifierPath + appId }; | ||
|
|
||
| THROW_IF_WIN32_ERROR(RegCreateKeyEx( |
There was a problem hiding this comment.
Does WIL have registry functions?
There was a problem hiding this comment.
I don't believe it does. But that would be very nice to have :)
|
I can't attach comments to unchanged lines so am putting it here instead. WindowsAppSDK/dev/AppNotifications/AppNotificationUtility.cpp Lines 75 to 81 in ce1563a This chunk of code generates a GUID with a known length then measures the length again, which isn't efficient. Instead you can perhaps do one of a few things (consult your nearest FTE for final guidance):
WindowsAppSDK/dev/AppNotifications/AppNotificationUtility.cpp Lines 353 to 355 in ce1563a
|
| @@ -175,7 +148,8 @@ int main() | |||
| const PACKAGE_VERSION minVersion{}; | |||
| RETURN_IF_FAILED(MddBootstrapInitialize(c_Version_MajorMinor, nullptr, minVersion)); | |||
|
|
|||
| SetDisplayNameAndIcon(); | |||
| // Not mandatory, but it's highly recommended to specify AppUserModelId | |||
| THROW_IF_FAILED(SetCurrentProcessExplicitAppUserModelID(L"TestAppId")); | |||
There was a problem hiding this comment.
@vaheeshta This is needed if we want apps to maintain their toast states even after a process name update later in the future. For example, if unpackaged app foo.exe has a name change to bar.exe in the future, this ensures that the apps toasts remain in the actioncentre. We should document.
There was a problem hiding this comment.
It also is needed if apps change their path from c:\foo\name.exe to d:\bar\name.exe.
There was a problem hiding this comment.
Got it. I'll document this once I have the unpackaged sample code.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danielayala94
dismissed stale reviews from DrusTheAxe and jonwis
I have addressed all comments. Thank you for reviewing this PR! 😊
|
|
||
| // Store the converted bitmap as ppToRenderBitmapSource | ||
| winrt::com_ptr<IWICBitmapSource> wicBitmapSourceConverted; | ||
| THROW_IF_FAILED(wicFormatConverter->QueryInterface(_uuidof(IWICBitmapSource), wicBitmapSourceConverted.put_void())); |
There was a problem hiding this comment.
(No change required)
I think this can be return wicFormatConverter.as<IWICBitmapSource>() ?
|
|
||
| THROW_IF_FAILED(wicFormatConverter->Initialize(wicBitmapSource.get(), guidPixelFormatSource, bitmapDitherType, nullptr, 0.f, WICBitmapPaletteTypeCustom)); | ||
|
|
||
| // Store the converted bitmap as ppToRenderBitmapSource |
No description provided.